[PATCH] D50655: [scudo] Fix race condition in deallocation path when Quarantine is bypassed

Evgenii Stepanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 13 14:00:36 PDT 2018


eugenis accepted this revision.
eugenis added a comment.
This revision is now accepted and ready to land.

I'm not very familiar with this code, but the change kind of makes sense.



================
Comment at: lib/scudo/scudo_allocator.cpp:392
                                    uptr Size) {
-    const bool BypassQuarantine = (Quarantine.GetCacheSize() == 0) ||
-        (Size > QuarantineChunksUpToSize);
----------------
why are you removing this condition?

(Quarantine.GetCacheSize() == 0)


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D50655





More information about the llvm-commits mailing list