[PATCH] D50497: [AliasSetTracker] Do not treat experimental_guard intrinsic as memory writing instruction

[Philip Reames via Phabricator via llvm-commits]

reames requested changes to this revision.
reames added a comment.
This revision now requires changes to proceed.

Request for additional specific tests has not been addressed.  See previous review comment.



================
Comment at: lib/Analysis/AliasSetTracker.cpp:173
 
-  if (!I->mayWriteToMemory()) {
+  // Some intrinsics are marked as modifying memory, but don't actually do it.
+  using namespace PatternMatch;
----------------
nitpick, but can you change this comment to:
// guards are marked as modifying memory for control flow modelling purposes, but don't actually modify any specific memory location.




https://reviews.llvm.org/D50497