[PATCH] D49985: [ADT] ImmutableList no longer requires elements to be copy constructible

Umann Kristóf via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 13 10:19:03 PDT 2018


Szelethus added a comment.

In https://reviews.llvm.org/D49985#1195588, @george.karpenkov wrote:

> In any case, tests are great, I really appreciate those, but I think we have established that the overall direction here does not make too much sense (or would require much more invasive changes)


I still don't see why we wouldn't like to remove the copy constructability restriction, to me the changes for it seem relatively non-invasive. However, can we at least add `static_assert(std::is_trivially_destructible<T>::value, ...)` to maybe save a developer from falling in the same pit?


https://reviews.llvm.org/D49985





More information about the llvm-commits mailing list