[PATCH] D50591: [PGO] Control Height Reduction

[David Li via Phabricator via llvm-commits]

davidxl added a comment.

The request for test case description also applies to other new test cases.



================
Comment at: test/Transforms/PGOProfile/chr.ll:8
+; Simple case
+define void @test_chr_1(i32* %i) !prof !14 {
+; CHECK-LABEL: @test_chr_1(
----------------
Also add a simple test case to make sure cold functions are skipped.


================
Comment at: test/Transforms/PGOProfile/chr.ll:14
+; CHECK-NEXT:    [[TMP2:%.*]] = icmp eq i32 [[TMP1]], 3
+; CHECK-NEXT:    br i1 [[TMP2]], label [[BB0:%.*]], label [[ENTRY_SPLIT_NONCHR:%.*]], !prof !15
+; CHECK:       bb0:
----------------
Can you add check of the meta data itself (for testing of profile meta data merging)?


================
Comment at: test/Transforms/PGOProfile/chr.ll:60
+; With an aggregate bit check
+define void @test_chr_2(i32* %i) !prof !14 {
+; CHECK-LABEL: @test_chr_2(
----------------
Can you add more detailed description of test case using C?


================
Comment at: test/Transforms/PGOProfile/chr.ll:121
+; Split case
+define void @test_chr_3(i32* %i) !prof !14 {
+; CHECK-LABEL: @test_chr_3(
----------------
Similarly add test case description.


Repository:
  rL LLVM

https://reviews.llvm.org/D50591