[PATCH] D50586: [Demangle] Add itaniumFindTypesInMangledName()

[Erik Pilkington via Phabricator via llvm-commits]

erik.pilkington added a comment.

> I think that's up to Erik mostly. Doing things this way definitely makes LLDB's life easier, but OTOH, I am generally trying to avoid cleaning up LLDB by pushing the mess into LLVM. This is not a particularly large mess, but it still a very odd specialized api that will only ever be used by a single customer.

That's true, and we should probably look for a cleaner way of doing this. At the moment though, I think that adding this (small) hack so we can remove the big hack that is FastDemangle is a really good tradeoff.

> I agree that the AST thing is a much bigger change, and originally I was planning to send an email to llvm-dev first (and probably I will at some point) after I clean things up, but your patches kinda forced my hand (I thought it was important for you to know that this is not a one-off thing, but there are other use cases for transforming mangled names). FWIW, I am fine with this going in and then being backed out once the more general framework is in, or just poking another hole for constructors if exposing the AST does not seem a good idea. That's particularly true as I cannot make much progress on that patch this week (though if either of you wants to pick that up, I wouldn't be offended :)).

Okay, look forward to seeing what you come up with!


https://reviews.llvm.org/D50586