[PATCH] D50629: AMDGPU: Fix getInstSizeInBytes
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 13 07:58:43 PDT 2018
arsenm added inline comments.
================
Comment at: lib/Target/AMDGPU/AMDGPUMCInstLower.cpp:320
+ LLVM_DEBUG(checkInstSize(*MI, TmpInst, STI, OutContext));
+
----------------
arsenm wrote:
> I strongly dislike assertion checks inside debug printing
Why can't you just assert after the instruction is emitted normally?
Repository:
rL LLVM
https://reviews.llvm.org/D50629
More information about the llvm-commits
mailing list