[PATCH] D49507: [Power9] Add __float128 support in the backend for bitcast to a i128

[Nemanja Ivanovic via Phabricator via llvm-commits]

nemanjai requested changes to this revision.
nemanjai added a comment.
This revision now requires changes to proceed.

This is definitely going to need a test case.



================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:14137
+    // Check if CRBits did anything and return that if it did.
+    if (CRTruncValue.getNode())
+      return CRTruncValue;
----------------
Why the call to `getNode()`? An `SDValue` is implicitly convertible to `bool` and will be false if this is a default-constructed one.


https://reviews.llvm.org/D49507