[PATCH] D50004: [PowerPC] Emit xscpsgndp instead of xxlor when copying floating point scalar registers for P9

Jinsong Ji via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 13 07:00:37 PDT 2018


jsji added a comment.

In https://reviews.llvm.org/D50004#1196993, @nemanjai wrote:

>




> It would appear that the version of the document I have has a bug in it (I had ISA 3.0 - without the `B`). Yes, I agree that the description in the corrected ISA document matches both of the provided examples.
>  However, I don't think this should preclude this patch. Register/register copies are far more common than destructive operations so we should emit the best instruction for the copy. As a follow-up, we should detect copies that are inputs to destructive operations and emit the `XXLOR` for those.

Yes, agree. It is OK as long as we will follow up for destructive operations. Thanks!


https://reviews.llvm.org/D50004





More information about the llvm-commits mailing list