[PATCH] D49879: [PowerPC] Generate Power9 extswsli extend sign and shift immediate instruction

[Nemanja Ivanovic via Phabricator via llvm-commits]

nemanjai added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:14118
+      N0.getOperand(0).getValueType() == MVT::i32 &&
+      isa<ConstantSDNode>(N1)) {
+
----------------
The use of `isa` followed by `cast` is discouraged. Please use `dyn_cast`. Then this can be turned into an early exit if any of the conditions are not met and the body of this block doesn't need to be nested in an `if`.


https://reviews.llvm.org/D49879