[PATCH] D50569: Change how we handle -wrap.

[Igor Kudrin via Phabricator via llvm-commits]

ikudrin added inline comments.


================
Comment at: lld/ELF/InputFiles.h:89
   // function on files of other types.
-  ArrayRef<Symbol *> getSymbols() {
+  std::vector<Symbol *> &getSymbols() {
     assert(FileKind == BinaryKind || FileKind == ObjKind ||
----------------
Don't you consider to add a method like `void remapSymbols(const DenseMap<Symbol *, Symbol *>&)` instead of this change?
I believe that granting the access to a protected member through a `get` method makes the behavior a bit unexpected. Note, that the original `getSymbols` method might be declared as `const`.


https://reviews.llvm.org/D50569