[PATCH] D50566: [Tablegen][SubtargetEmitter] Improve expansion of predicates of a variant scheduling class.

[Andrea Di Biagio via Phabricator via llvm-commits]

andreadb added inline comments.


================
Comment at: utils/TableGen/SubtargetEmitter.cpp:1487
   raw_string_ostream StringStream(Buffer);
   formatted_raw_ostream FOS(StringStream);
 
----------------
craig.topper wrote:
> Not related to this patch, but is formatted_raw_ostream really needed here? Can we use indent instead of PadToColumn? formatted_raw_ostream has to do internal tracking of column and thus scans every print for a new line character.
Good point.
We can definitely use PadToColumn in this function.
We can also change the PredicateExpander, so that method `expandPredicate()`  doesn't require a `formatted_raw_ostream`.
I'll think about it and see if I can send it as a follow-up NFC patch.

Thanks!


https://reviews.llvm.org/D50566