[PATCH] D50494: [LLD] Reserve memory in implicitly set LMARegions
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 13 01:55:15 PDT 2018
grimar added inline comments.
================
Comment at: ELF/LinkerScript.cpp:780
+
+void LinkerScript::setLMARegion(OutputSection *Sec) {
+
----------------
kschwarz wrote:
> grimar wrote:
> > I tried to simplify the conditions in this method and ended up with the following version: D50602.
> > What do you think?
> Your version is also fine for me, and has better reusability. I added minor comments in the separate review.
>
Please feel free to use it whole or partially for this patch. Its intention was to show/suggest the slightly different approach.
Repository:
rLLD LLVM Linker
https://reviews.llvm.org/D50494
More information about the llvm-commits
mailing list