[PATCH] D50426: [NFC][MustExecute] Rework API to start making better analysis
Fedor Sergeev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Aug 12 13:07:55 PDT 2018
fedor.sergeev added inline comments.
================
Comment at: include/llvm/Analysis/MustExecute.h:53
+
+ bool mayThrow(const BasicBlock *BB);
+
----------------
reames wrote:
> Should be const functions.
This most definitely is a "preparation" for D50377, where LoopSafetyInfo gets more state and mayThrow becomes non-const.
Said that, I do question the need for doing a separate API change that goes w/o a semantical context that necessitates the change.
https://reviews.llvm.org/D50426
More information about the llvm-commits
mailing list