[PATCH] D50604: [InstCombine] Replace call to haveNoCommonBitsSet in visitXor with just the special case that doesn't use computeKnownBits.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 12 01:12:01 PDT 2018


craig.topper added a comment.

We don't currently turn Add into Or inside SimplifyDemandedBits so visitAdd doesn't have this issue. I'm a little skeptical that we should be aggressively turning adds into ors. I plan to start an llvm-dev thread on that.

I believe this is NFC based on my understanding of SimplifyDemandedInstructionBits and haveNoCommonBitSet.


Repository:
  rL LLVM

https://reviews.llvm.org/D50604





More information about the llvm-commits mailing list