[PATCH] D50566: [Tablegen][SubtargetEmitter] Improve expansion of predicates of a variant scheduling class.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Aug 11 22:52:50 PDT 2018


craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: utils/TableGen/SubtargetEmitter.cpp:1487
   raw_string_ostream StringStream(Buffer);
   formatted_raw_ostream FOS(StringStream);
 
----------------
Not related to this patch, but is formatted_raw_ostream really needed here? Can we use indent instead of PadToColumn? formatted_raw_ostream has to do internal tracking of column and thus scans every print for a new line character.


https://reviews.llvm.org/D50566





More information about the llvm-commits mailing list