[PATCH] D49678: [llvm-objcopy] Adding support for compressed DWARF debug sections.

[Puyan Lotfi via Phabricator via llvm-commits]

plotfi marked 9 inline comments as done.
plotfi added inline comments.


================
Comment at: include/llvm/Object/Compressor.h:34
+  /// @param W Destination buffer stream for compressed data.
+  Error writeCompressedSectionData(support::endian::Writer &W) {
+    SmallVector<char, 128> CompressedBuffer;
----------------
jhenderson wrote:
> Don't abbreviate, if you can avoid it: W -> Writer, E ->Err, here and elsewhere in this file.
> 
> This function could probably be moved into the .cpp.
Why? There's just so much LLVM code that uses this convention. Literally every single place I see support::endian::Writer the Writer is called W (or LE or OSE). For Error I see E and Err use pretty interchangeably in the codebase. 


Repository:
  rL LLVM

https://reviews.llvm.org/D49678