[PATCH] D50469: AMDGPU: Check NSZ MI flag when folding omod

[Marek Olšák via Phabricator via llvm-commits]

mareko accepted this revision.
mareko added a comment.
This revision is now accepted and ready to land.

Accepted.



================
Comment at: lib/Target/AMDGPU/SIFoldOperands.cpp:998
   // TODO: Check nsz on instructions when fast math flags are preserved to MI
   // level.
+  bool IsIEEEMode = ST->enableIEEEBit(MF);
----------------
Is this TODO still needed?


================
Comment at: test/CodeGen/AMDGPU/omod-nsz-flag.mir:20
+
+# FIXME: Is it OK to fold omod for this?
+# GCN-LABEL: name: omod_inst_flag_nsz_src
----------------
Not sure, though I guess it doesn't matter, because we set nsz for whole shaders, which hopefully gets propagated to all instructions.


https://reviews.llvm.org/D50469