[PATCH] D50593: ConstantMerge: merge common initial sequences

JF Bastien via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 10 17:26:07 PDT 2018


jfb added a comment.

Overall this is ready to review. I ran a bunch of tests and tried it out with asan, everything seems happy, but I'm a bit paranoid. I'm re-running the test-suite before / after the change to make sure everything works as I expect it to.



================
Comment at: test/Transforms/ConstantMerge/initial-match.ll:78
+
+; FIXME: test that two zeroinitializer things get common initial sequence deduplication. Ditto undef.
+
----------------
I'll look into this soon :)


Repository:
  rL LLVM

https://reviews.llvm.org/D50593





More information about the llvm-commits mailing list