[PATCH] D49887: [DebugInfo] Add support for DWARF5 call site-related attributes

[Vedant Kumar via Phabricator via llvm-commits]

vsk updated this revision to Diff 160200.
vsk marked 4 inline comments as done.
vsk added a comment.

Thanks for your feedback @dblaikie! I've addressed some of it and responded to the rest inline.

- Add dsymutil support for relocating the contents of DW_AT_call_return_pc. Now, these addresses are useful to lldb. @friss & @JDevlieghere I've never looked, would appreciate any comments you may have here.
- Rebase & address some review comments.


https://reviews.llvm.org/D49887

Files:
  clang/lib/CodeGen/CGDebugInfo.cpp
  clang/lib/CodeGen/CGDebugInfo.h
  clang/test/CodeGenCXX/dbg-info-all-calls-described.cpp
  llvm/include/llvm/DebugInfo/DWARF/DWARFVerifier.h
  llvm/include/llvm/IR/DebugInfoFlags.def
  llvm/include/llvm/IR/DebugInfoMetadata.h
  llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp
  llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.h
  llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
  llvm/lib/CodeGen/AsmPrinter/DwarfDebug.h
  llvm/lib/DebugInfo/DWARF/DWARFVerifier.cpp
  llvm/lib/IR/Verifier.cpp
  llvm/test/DebugInfo/Generic/callsite-attr-invalid.ll
  llvm/test/DebugInfo/X86/dwarf-callsite-related-attrs.ll
  llvm/test/DebugInfo/X86/dwarfdump-callsite-invalid-1.s
  llvm/test/tools/dsymutil/Inputs/call-site-entry.c
  llvm/test/tools/dsymutil/Inputs/call-site-entry.macho.x86_64
  llvm/test/tools/dsymutil/Inputs/call-site-entry.macho.x86_64.o
  llvm/test/tools/dsymutil/call-site-entry-linking.test
  llvm/tools/dsymutil/DwarfLinker.cpp
  llvm/tools/llvm-dwarfdump/Statistics.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D49887.160200.patch
Type: text/x-patch
Size: 52226 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180810/3769e211/attachment.bin>