[PATCH] D50016: IR: Add entry/exit instrumentation symbols to the libcall list.

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/EntryExitInstrumenter.cpp:23
                        Instruction *InsertionPt, DebugLoc DL) {
+  // If you add code to recognize a new instrumentation function here, the
+  // function also needs to be added to include/llvm/IR/RuntimeLibcalls.def
----------------
pcc wrote:
> tejohnson wrote:
> > Can you include RuntimeLibcalls.def and assert that the name is in that list?
> I could, but I don't think we need to do that unless there's evidence that people are ignoring the comment.
I'd prefer an assert, because I think it would be easy to miss the comment if the second if block is extended with another func name, or a subsequent new if block is added below it.


Repository:
  rL LLVM

https://reviews.llvm.org/D50016