[compiler-rt] r339449 - [hwasan] Remove liblog dependency.

Evgeniy Stepanov via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 10 09:38:57 PDT 2018


Author: eugenis
Date: Fri Aug 10 09:38:57 2018
New Revision: 339449

URL: http://llvm.org/viewvc/llvm-project?rev=339449&view=rev
Log:
[hwasan] Remove liblog dependency.

HWASan will not run on older Android releases where we use
__android_log_write for logging.

This dependency is also harmful in the case when libc itself depends
on hwasan, because it creates a loop of
  libc -> hwasan -> liblog -> libc
which makes liblog vs libc initialization order undetermined.

Without liblog the loop is just
  libc -> hwasan -> libc
and any init order issues can be solved in hwasan.

Modified:
    compiler-rt/trunk/lib/hwasan/CMakeLists.txt

Modified: compiler-rt/trunk/lib/hwasan/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/hwasan/CMakeLists.txt?rev=339449&r1=339448&r2=339449&view=diff
==============================================================================
--- compiler-rt/trunk/lib/hwasan/CMakeLists.txt (original)
+++ compiler-rt/trunk/lib/hwasan/CMakeLists.txt Fri Aug 10 09:38:57 2018
@@ -47,7 +47,6 @@ append_list_if(COMPILER_RT_HAS_LIBDL dl
 append_list_if(COMPILER_RT_HAS_LIBRT rt HWASAN_DYNAMIC_LIBS)
 append_list_if(COMPILER_RT_HAS_LIBM m HWASAN_DYNAMIC_LIBS)
 append_list_if(COMPILER_RT_HAS_LIBPTHREAD pthread HWASAN_DYNAMIC_LIBS)
-append_list_if(COMPILER_RT_HAS_LIBLOG log HWASAN_DYNAMIC_LIBS)
 
 # Static runtime library.
 add_compiler_rt_component(hwasan)




More information about the llvm-commits mailing list