[PATCH] D50413: [libunwind][include] Add some missing definitions to <unwind.h>.

Charles Davis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 10 09:04:18 PDT 2018


cdavis5x added a comment.

In https://reviews.llvm.org/D50413#1195101, @mstorsjo wrote:

> @cdavis5x I presume the fact that this one turned out tricky is blocking submitting the SEH unwinding patch.
>
> Would it be worth to rework that patch to just use the basic types just like libunwind does today, e.g. having `_Unwind_GetRegionStart` return plain `uintptr_t` instead of `_Unwind_Ptr`, which also would be consistent with the existing entry points in Unwind-EHABI.cpp, Unwind-sjlj.c and UnwindLevel1.c, in order to be able to submit it before this one gets sorted out?


Sounds reasonable.


Repository:
  rUNW libunwind

https://reviews.llvm.org/D50413





More information about the llvm-commits mailing list