[PATCH] D50431: generalize SKS key server in debian8 Dockerfile

Ilya Biryukov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 10 06:59:57 PDT 2018


ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.

Sure, LGTM, did not want to block you.

If you're interested in further improvements, the idea is to:

1. remove all references to gpg from the script.
2. hard-code the SHA256 in the script and use it to validate the download, i.e.

  echo "0e6ec35d4fa9bf79800118916b51928b6471d5725ff36f1d0de5ebb34dcd5406 cmake-3.7.2-Linux-x86_64.tar.gz" | \
        sha256sum -c -


Repository:
  rL LLVM

https://reviews.llvm.org/D50431





More information about the llvm-commits mailing list