[PATCH] D50252: [ARM] Added Codegen support for vrev64q_f16 vector intrinsics

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.

Looks like a straight forward fix to me now.

Apologies for fixing vext, I forgot and was also not expecting you were fixing both vrev and vext in one ticket.

One nit you could think about in e.g. your commit message: it's true this adds support for vrev64q_f16, but the added pattern are generic patterns for vrev on f16 vector with 4 or 8 elements; so something along the lines of "FP16 vrev codegen support" is more generic, and perhaps capturing it better.


https://reviews.llvm.org/D50252