[PATCH] D50483: [SanitizerCoverage] Add associated metadata to PC guards.

Matt Morehouse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 9 16:10:49 PDT 2018


morehouse added a comment.

libFuzzer relies on there being the same number of guards as PC table entries, and assumes they are in the same order:  https://github.com/llvm-mirror/compiler-rt/blob/dafd5b461e1808fce4a76da13b81065968eff6aa/lib/fuzzer/FuzzerTracePC.cpp#L220

This assumption held until I added associated metadata to PC tables a while back.  After that the number of guards still match, but the ordering doesn't.  I don't fully understand what the linker is doing either, but adding the metadata to the guards causes the order to match again.


https://reviews.llvm.org/D50483





More information about the llvm-commits mailing list