[PATCH] D50491: [DAGCombiner][AMDGPU][Mips] Fold bitcast with volatile loads if the resulting load is legal for the target.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 9 16:00:59 PDT 2018


craig.topper added a comment.

So the isOperationLegal check here should prevent (i64 (bitcast (f64 volatile load))) from being changed on x86-32. Do I need to make sure sure that i64 is legal to prevent (f64 (bitcast (i64 volatile load))) from being changed? The comments from r52254 where this check was originally added seems to suggest that its bad to increase the number of operations and that the number of operations needed for an illegal type is "undefined".


Repository:
  rL LLVM

https://reviews.llvm.org/D50491





More information about the llvm-commits mailing list