[llvm] r339390 - ConstantMerge: update MadeChange when change is made

[Davide Italiano via llvm-commits]

you should be able to test this relatively easily, just dump the pass
manager pipeline after this has run and make sure the analyses are
recomputed.
Can you please do that?
On Thu, Aug 9, 2018 at 2:37 PM JF Bastien via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
>
> Author: jfb
> Date: Thu Aug  9 14:36:57 2018
> New Revision: 339390
>
> URL: http://llvm.org/viewvc/llvm-project?rev=339390&view=rev
> Log:
> ConstantMerge: update MadeChange when change is made
>
> It was always false, which is obviously wrong.
>
> Modified:
>     llvm/trunk/lib/Transforms/IPO/ConstantMerge.cpp
>
> Modified: llvm/trunk/lib/Transforms/IPO/ConstantMerge.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/IPO/ConstantMerge.cpp?rev=339390&r1=339389&r2=339390&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Transforms/IPO/ConstantMerge.cpp (original)
> +++ llvm/trunk/lib/Transforms/IPO/ConstantMerge.cpp Thu Aug  9 14:36:57 2018
> @@ -220,6 +220,7 @@ static bool mergeConstants(Module &M) {
>        assert(Replacements[i].first->hasLocalLinkage() &&
>               "Refusing to delete an externally visible global variable.");
>        Replacements[i].first->eraseFromParent();
> +      MadeChange = true;
>      }
>
>      NumMerged += Replacements.size();
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits



-- 
Davide

"There are no solved problems; there are only problems that are more
or less solved" -- Henri Poincare