[PATCH] D49514: [compiler-rt] [builtins] Add logb/logbf/logbl methods to compiler-rt to avoid libm dependencies when possible.

Jordan Rupprecht via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 9 15:16:14 PDT 2018


rupprecht added inline comments.


================
Comment at: lib/builtins/divxc3.c:16
 
+#define QUAD_PRECISION
+#include "fp_lib.h"
----------------
rupprecht wrote:
> efriedma wrote:
> > Could you use a define that isn't QUAD_PRECISION here?  Or just skip changing this file for now?  This is the x86 80-bit long double.
> > Could you use a define that isn't QUAD_PRECISION here? Or just skip changing this file for now? This is the x86 80-bit long double.
> > 
> 
> 80-bit long double doesn't fit the abstractions used in fp_lib.h, so I'll just skip for now.
Just realized I reverted the wrong one -- fixed so that I'm skipping divxc3 in this revision, but including divtc3 (both generic and ppc versions)


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D49514





More information about the llvm-commits mailing list