[PATCH] D50343: [llvm-objcopy] Add support for -I binary -B <arch>.

[Jake Ehrlich via Phabricator via llvm-commits]

jakehehrlich added a comment.

Awesome! I'd like to have someone else look over this but this pretty well LGTM.



================
Comment at: tools/llvm-objcopy/Object.cpp:614
+  SymTab.Link = size(Obj->sections()) - 1;
+  SymTab.EntrySize = sizeof(Elf_Sym);
+
----------------
And this is the last thing where we can't easily factor out dependence on ElfType. This is going to require that Size be handled differently from how it is now. I'm not going to block this change on that since the fix is just not simple. Under the current design of llvm-objcopy that would require a new visitor to calculate the size. I'm not sure I want to further things along that path.

Can you add a TODO here for me?


Repository:
  rL LLVM

https://reviews.llvm.org/D50343