[PATCH] D50422: SCEV should forget all loops containing a deleted block.

[David Greene via Phabricator via llvm-commits]

greened added inline comments.


================
Comment at: test/Transforms/LoopIdiom/scev-invalidation_topmostloop.ll:5
+
+define void @f1() {
+entry:
----------------
mkazantsev wrote:
> Please add `| FileCheck %s` to command line and smth like `CHECK: @f1` in the test itself.
Is this actually testing the functionality of this change?  I'm wondering how this problem was discovered.  If it was a miscompilation, we should have a test that ensures we don't reintroduce the problem.  If it was discovered by inspection,. then I'm guessing constructing a proper test would be difficult.  I asked about a test not as a demand to produce one but rather to try to see if we have an actual observed problem we could capture in a test.  If we don't I'm not sure constructing a test that doesn't actually test anything is useful.


Repository:
  rL LLVM

https://reviews.llvm.org/D50422