[PATCH] D50441: [XRay] FDR Trace Dump Tool (FDR Trace Loading Refactor)
Keith via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 9 10:22:52 PDT 2018
kpw added a comment.
Thought that occurred to me this morning:
This models a sequence of records and not a more complex structure like a tree. Instead of greedily filling a vector and then calling visitors, this could be better done with a streaming model.
The "driver" code would maintain a sequence of visitors and call them on each record that it reads.
It should be a small refactoring and could dramatically improve memory use especially for stateless visitors like the printer.
https://reviews.llvm.org/D50441
More information about the llvm-commits
mailing list