[PATCH] D50433: A New Divergence Analysis for LLVM

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: include/llvm/Analysis/KernelDivergenceAnalysis.h:1
-//===- llvm/Analysis/DivergenceAnalysis.h - Divergence Analysis -*- C++ -*-===//
+//===- llvm/Analysis/KernelDivergenceAnalysis.h - KernelDivergence Analysis -*- C++ -*-===//
 //
----------------
simoll wrote:
> arsenm wrote:
> > arsenm wrote:
> > > I don't like the use of the name kernel here. This has nothing to do with kernels, and works fine for non-kernel functions (ignoring the flaws with the pass0
> > Better option might just be DivergenceAnalysisLegacy?
> Would `LegacyDivergenceAnalysis` be ok?
> 
> I think that `Legacy` as a suffix suggests that this was a pass for the legacy pass manager (and not deprecated in itself). There is precedent for `Legacy`-as-a-prefix in `llvm/ExecutionEngine/JITSymbol.h` (`LegacyJITSymbolResolver`)
Sure


Repository:
  rL LLVM

https://reviews.llvm.org/D50433