[PATCH] D50499: [X86] Constant folding of adds/subs intrinsics

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 9 05:18:05 PDT 2018


spatel added reviewers: chandlerc, efriedma.
spatel added a comment.

The title of this patch includes "Constant folding" - shouldn't the code be in ConstantFolding.cpp or some descendant of that?

I remember that there was a suggestion (years ago?) to split target-specific logic like this into its own files because other targets shouldn't be burdened with code that will never affect them, but this hasn't happened yet. There's x86-specific intrinsic code in ConstantFolding.cpp added with https://reviews.llvm.org/rL123206.


Repository:
  rL LLVM

https://reviews.llvm.org/D50499





More information about the llvm-commits mailing list