[PATCH] D50371: Split-stack support for cross-linking shared-libraries.

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: test/ELF/x86-64-split-stack-prologue-adjust-shared.s:6
+# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t1.o
+# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %p/Inputs/x86-64-split-stack-main.s -o %t3.o
+# RUN: ld.lld --defsym __morestack=0x100 --defsym __morestack_non_split=0x200 %t1.o %t3.o %t4.so -o %t -z notext 
----------------
What I not understand is why do you need this file here?
You have a caller (x86-64-split-stack-prologue-adjust-shared.s) and a shared library (x86-64-split-stack-extra.s),
is not that enough for testing the call?

Also, why do you have to use `-z notext` below?

I was able to remove both the file and the option and test case still passed for me.
So could you please reduce it to minimal possible? That is the desired way to write the test cases we are trying to follow usually.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D50371