[PATCH] D49678: [llvm-objcopy] Adding support for compressed DWARF debug sections.

[Puyan Lotfi via Phabricator via llvm-commits]

plotfi added inline comments.


================
Comment at: test/tools/llvm-objcopy/zlib-dwarf.test:8-12
+# This produces a small shell script that takes an object file, reads out and
+# sorts its debug section names, and then in sorted order it runs llvm-objdump
+# (via xargs) on each debug section while redirecting that output to a text
+# file. We compare the txt files of the original vs zlib vs zlib-gnu
+# round-tripping.
----------------
jhenderson wrote:
> Why is this sorting necessary? The section order will be the same, won't it? Why do you need more than one debug section for this test? Why is this test so much more complex than zlib-dwarf-gnu-roundtrip.test?
The sorting is necessary because we append new sections to the end of the object so the compressed sections come at the end and not in the same place they where. I could replace all this with something like echo ".debug_abbrev .debug_info .debug_line .debug_pubnames .debug_str" | xargs -I% llvm-objdump -s -section=% %s > foo.txt


Repository:
  rL LLVM

https://reviews.llvm.org/D49678