[PATCH] D50479: Expose CFG Update struct. Define GraphTraits to get children given a snapshot CFG.

Alina Sbirlea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 8 15:04:31 PDT 2018


asbirlea added a comment.

Looking for feedback on this before moving forward. Some questions:

1. Namespace naming (cfg) and placement of Update struct.
2. Move WrappedPairNodeDataIterator somewhere in ADT, to reuse in LoopIterator.h?
3. The part to pre-process the Updates is not part of this patch. I would like to move GenericDomTreeConstruction::LegalizeUpdates somewhere in Support outside DomTreeBuilder namespace, in order to reuse the functionality. Where is a good place to have this, or are there objections to moving it?

Should these follow-up patches be part of this one?

1. Reference cfg::Update in DomTree, remove Update from DomTreeBuilder namespace.
2. Teach IDF to use children based on a GraphDiff, given the new GraphTraits in this patch.


Repository:
  rL LLVM

https://reviews.llvm.org/D50479





More information about the llvm-commits mailing list