[PATCH] D50423: [WebAssembly] Gate i64x2 and f64x2 on -wasm-enable-unimplemented

[Derek Schuff via Phabricator via llvm-commits]

dschuff added inline comments.


================
Comment at: lib/Target/WebAssembly/WebAssemblyFastISel.cpp:690
+      if (!EnableUnimplementedWasmInstrs)
+        llvm_unreachable("unexpected argument type");
       Opc = WebAssembly::ARGUMENT_v2i64;
----------------
I don't think it's necessary to have checks at every single place where these types are used. It's enough e.g. to prevent them from reaching here with a check somewhere else, but still handle everything once the instructions get here. (Basically the same reason we have unconditional definitions and handling for simd instructions in some places, but have checks on the SIMD cpu feature in other places.


Repository:
  rL LLVM

https://reviews.llvm.org/D50423