[PATCH] D50473: [Demangle] Add another test for ItaniumPartialDemangler

Erik Pilkington via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 8 14:09:48 PDT 2018


erik.pilkington accepted this revision.
erik.pilkington added a comment.
This revision is now accepted and ready to land.

LGTM, thanks for doing this!



================
Comment at: unittests/Demangle/PartialDemangleTest.cpp:188
+    size_t N = OriginalSize;
+    char *Res = D.getFunctionName(Buf, &N);
+    EXPECT_EQ(nullptr, Res);
----------------
Does LLDB actually pass in a N that is less than the length of Buf? Its not wrong to do that per se, realloc will sort it out, but it seems kinda strange.


Repository:
  rL LLVM

https://reviews.llvm.org/D50473





More information about the llvm-commits mailing list