[PATCH] D50450: Add R_HEX_6_X relocation support

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM with these changes.



================
Comment at: ELF/Arch/Hexagon.cpp:69
+static uint32_t findMaskR6(uint32_t Insn) {
+
+  // There are (arguably too) many relocation masks for the DSP's
----------------
nit: remove the blank line.


================
Comment at: ELF/Arch/Hexagon.cpp:78
+
+  static const struct InstructionMask R6[] = {
+      {0x38000000, 0x0000201f}, {0x39000000, 0x0000201f},
----------------
I believe you can remove the `struct` keyword from this line in C++.


================
Comment at: ELF/Arch/Hexagon.cpp:103
+
+  error("Unrecognized instruction for R_HEX_6 relocation: 0x" +
+        Twine().utohexstr(Insn));
----------------
Error messages should start with a lowercase letter.


================
Comment at: ELF/Arch/Hexagon.cpp:104
+  error("Unrecognized instruction for R_HEX_6 relocation: 0x" +
+        Twine().utohexstr(Insn));
+}
----------------
Remove `Twine().`. We have `llvm::utohexstr` and you can use that.


https://reviews.llvm.org/D50450