[PATCH] D50423: [WebAssembly] Gate i64x2 and f64x2 on -wasm-enable-unimplemented

[Heejin Ahn via Phabricator via llvm-commits]

aheejin added inline comments.


================
Comment at: lib/Target/WebAssembly/WebAssemblyAsmPrinter.cpp:45
 
+extern cl::opt<bool> EnableUnimplementedWasmInstrs;
+
----------------
aheejin wrote:
> tlively wrote:
> > tlively wrote:
> > > dschuff wrote:
> > > > Could putting this declaration in WebAssemblyTargetMachine.h avoid all these extern declarations?
> > > Not all, just some.
> > It also doesn't work that way because you end up with duplicate symbols.
> I guess what he meant is putting the definition where it is now and putting that `extern` declaration in the header file, but anyway.
Would WebAssembly.h work then?


Repository:
  rL LLVM

https://reviews.llvm.org/D50423