[PATCH] D50423: [WebAssembly] Gate i64x2 and f64x2 on -wasm-enable-unimplemented
Thomas Lively via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 8 11:06:32 PDT 2018
tlively added inline comments.
================
Comment at: lib/Target/WebAssembly/WebAssemblyAsmPrinter.cpp:45
+extern cl::opt<bool> EnableUnimplementedWasmInstrs;
+
----------------
tlively wrote:
> dschuff wrote:
> > Could putting this declaration in WebAssemblyTargetMachine.h avoid all these extern declarations?
> Not all, just some.
It also doesn't work that way because you end up with duplicate symbols.
Repository:
rL LLVM
https://reviews.llvm.org/D50423
More information about the llvm-commits
mailing list