[PATCH] D50301: [InstCombine] De Morgan: sink 'not' into 'xor' (PR38446)

[Sanjay Patel via Phabricator via llvm-commits]

spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lib/Transforms/InstCombine/InstCombineAndOrXor.cpp:2464
+  Value *X, *Y;
+  if (!match(&I, m_Not(m_OneUse(m_Xor(m_Value(X), m_Value(Y))))))
+    return nullptr;
----------------
The one-use here is not strictly necessary? There are questions about how to best deal with inverted compares, so I don't think it needs to hold this patch up, but it's worth a code comment if I'm seeing it correctly. 

This reminded me of the still open:
D35182



Repository:
  rL LLVM

https://reviews.llvm.org/D50301