[PATCH] D50413: [libunwind][include] Add some missing definitions to <unwind.h>.
    Martin Storsjö via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Tue Aug  7 23:17:53 PDT 2018
    
    
  
mstorsjo added inline comments.
================
Comment at: include/unwind.h:46
+typedef uintptr_t _Unwind_Ptr;
+#endif
+
----------------
What other reference is this list of typedefs for `_Unwind_Ptr` based on? I don't see any of these cases in clang's unwind.h at least.
================
Comment at: include/unwind.h:172
        struct _Unwind_Context* context);
+typedef _Unwind_Personality_Fn __personality_routine;
 #endif
----------------
Minor nitpick: Would it make sense to move the `typedef _Unwind_Personality_Fn __personality_routine;` out of the ifdef, since the same one can be used for both cases?
Repository:
  rUNW libunwind
https://reviews.llvm.org/D50413
    
    
More information about the llvm-commits
mailing list