[PATCH] D50397: [lit, python3] Update lit error logging to work correctly in python3 and other test fixes

[Stella Stamenova via Phabricator via llvm-commits]

stella.stamenova added a comment.

In https://reviews.llvm.org/D50397#1191201, @zturner wrote:

> We have a function somewhere in lit utils that does this, but I’m OOO so I
>  can’t look for it. Can you try to find it?


You are thinking of to_string in util.py. I could use it here, but the code in Test.py explicitly ignores any errors from the encode/decode calls while to_string raises an exception when it fails to encode. I could modify to_string to take an optional parameter to determine whether to raise an exception instead of having some of the same functionality in Test.py.


Repository:
  rL LLVM

https://reviews.llvm.org/D50397