[PATCH] D50197: [DebugInfo/DWARF] Try to make a loop more readable. NFC

Paul Robinson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 7 10:47:22 PDT 2018


probinson abandoned this revision.
probinson added a comment.

I'm abandoning this minor tweak as I am convinced that there is something more fundamentally wrong here.
llvm-dwarfdump doesn't call the right API sequence to show the bug; it requires a DWP, looking up a specific unit by hash via the DWP index, and then scanning all the units.  I can envision how to do a unittest for that, but the unittest infrastructure doesn't currently support building a DWP.  I can't take the time right now to address this, but I'll keep it on The List.


Repository:
  rL LLVM

https://reviews.llvm.org/D50197





More information about the llvm-commits mailing list