[PATCH] D50143: [SLP] Fix insert point for reused extract instructions.
Alexey Bataev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 7 09:51:18 PDT 2018
ABataev added inline comments.
================
Comment at: lib/Transforms/Vectorize/SLPVectorizer.cpp:3112
// TODO: Merge this shuffle with the ReorderShuffleMask.
- if (!E->ReorderIndices.empty())
+ if (E->ReorderIndices.empty())
Builder.SetInsertPoint(VL0);
----------------
efriedma wrote:
> Please add a test for the case where `NeedToShuffleReuses` is true and `E->ReorderIndices.empty()` is false.
We already have that kind of test `X86/vectorize-reorder-reuse.ll`, but I'll add another one.
Repository:
rL LLVM
https://reviews.llvm.org/D50143
More information about the llvm-commits
mailing list