[PATCH] D50236: [ARM] FP16: support VACGT

Oliver Stannard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 7 07:23:55 PDT 2018


olista01 accepted this revision.
olista01 added a comment.
This revision is now accepted and ready to land.

Ont nit, other than that LGTM.



================
Comment at: test/CodeGen/ARM/armv8.2a-fp16-vector-intrinsics.ll:525
 
-; FIXME (PR38404)
-;
-;define dso_local <4 x i16> @test_vcagt_f16(<4 x half> %a, <4 x half> %b) {
-;entry:
-;  %vcagt_v2.i = tail call <4 x i16> @llvm.arm.neon.vacgt.v4i16.v4f16(<4 x half> %a, <4 x half> %b)
-;  ret <4 x i16> %vcagt_v2.i
-;}
-;
-;define dso_local <8 x i16> @test_vcagtq_f16(<8 x half> %a, <8 x half> %b) {
-;entry:
-;  %vcagtq_v2.i = tail call <8 x i16> @llvm.arm.neon.vacgt.v8i16.v8f16(<8 x half> %a, <8 x half> %b)
-;  ret <8 x i16> %vcagtq_v2.i
-;}
+define dso_local <4 x i16> @test_vcagt_f16(<4 x half> %a, <4 x half> %b) {
+; CHECK-LABEL: test_vcagt_f16:
----------------
The test is "vcagt", but the intrincic/instruction is "vacgt".


https://reviews.llvm.org/D50236





More information about the llvm-commits mailing list