[PATCH] D50379: New ImageProcessing tests were failing becuase c++ flags are used in c flags.

[santosh z via Phabricator via llvm-commits]

santosh updated this revision to Diff 159487.
santosh added a comment.

Just added test Microbenchmark test Interpolation has the same issue.


Repository:
  rT test-suite

https://reviews.llvm.org/D50379

Files:
  MicroBenchmarks/ImageProcessing/AnisotropicDiffusion/CMakeLists.txt
  MicroBenchmarks/ImageProcessing/Blur/CMakeLists.txt
  MicroBenchmarks/ImageProcessing/Dither/CMakeLists.txt
  MicroBenchmarks/ImageProcessing/Interpolation/CMakeLists.txt


Index: MicroBenchmarks/ImageProcessing/Interpolation/CMakeLists.txt
===================================================================
--- MicroBenchmarks/ImageProcessing/Interpolation/CMakeLists.txt
+++ MicroBenchmarks/ImageProcessing/Interpolation/CMakeLists.txt
@@ -1,5 +1,6 @@
 set(IMAGEPROC_UTILS MicroBenchmarks/ImageProcessing/utils)
-list(APPEND CPPFLAGS -I ${CMAKE_SOURCE_DIR}/${IMAGEPROC_UTILS} -std=c++11)
+list(APPEND CPPFLAGS -I ${CMAKE_SOURCE_DIR}/${IMAGEPROC_UTILS})
+list(APPEND CXX_FLAGS -std=c++11)
 
 llvm_test_verify("${CMAKE_SOURCE_DIR}/HashProgramOutput.sh ${CMAKE_CURRENT_BINARY_DIR}/bicubicOutput.txt")
 llvm_test_verify("${FPCMP} ${CMAKE_CURRENT_BINARY_DIR}/bicubicOutput.txt ${CMAKE_CURRENT_SOURCE_DIR}/bicubic.reference_output")
Index: MicroBenchmarks/ImageProcessing/Dither/CMakeLists.txt
===================================================================
--- MicroBenchmarks/ImageProcessing/Dither/CMakeLists.txt
+++ MicroBenchmarks/ImageProcessing/Dither/CMakeLists.txt
@@ -1,5 +1,6 @@
 set(IMAGEPROC_UTILS MicroBenchmarks/ImageProcessing/utils)
-list(APPEND CPPFLAGS -I ${CMAKE_SOURCE_DIR}/${IMAGEPROC_UTILS} -std=c++11)
+list(APPEND CPPFLAGS -I ${CMAKE_SOURCE_DIR}/${IMAGEPROC_UTILS})
+list(APPEND CXX_FLAGS -std=c++11)
 
 llvm_test_verify("${CMAKE_SOURCE_DIR}/HashProgramOutput.sh ${CMAKE_CURRENT_BINARY_DIR}/orderedOutput.txt")
 llvm_test_verify("${FPCMP} ${CMAKE_CURRENT_BINARY_DIR}/orderedOutput.txt ${CMAKE_CURRENT_SOURCE_DIR}/orderedDither.reference_output")
Index: MicroBenchmarks/ImageProcessing/Blur/CMakeLists.txt
===================================================================
--- MicroBenchmarks/ImageProcessing/Blur/CMakeLists.txt
+++ MicroBenchmarks/ImageProcessing/Blur/CMakeLists.txt
@@ -1,6 +1,7 @@
 set(IMAGEPROC_UTILS MicroBenchmarks/ImageProcessing/utils)
 
-list(APPEND CPPFLAGS -I ${CMAKE_SOURCE_DIR}/${IMAGEPROC_UTILS} -std=c++11)
+list(APPEND CPPFLAGS -I ${CMAKE_SOURCE_DIR}/${IMAGEPROC_UTILS})
+list(APPEND CXX_FLAGS -std=c++11)
 
 llvm_test_verify("${CMAKE_SOURCE_DIR}/HashProgramOutput.sh ${CMAKE_CURRENT_BINARY_DIR}/boxBlurOutput.txt")
 llvm_test_verify("${FPCMP} ${CMAKE_CURRENT_BINARY_DIR}/boxBlurOutput.txt ${CMAKE_CURRENT_SOURCE_DIR}/boxBlur.reference_output")
Index: MicroBenchmarks/ImageProcessing/AnisotropicDiffusion/CMakeLists.txt
===================================================================
--- MicroBenchmarks/ImageProcessing/AnisotropicDiffusion/CMakeLists.txt
+++ MicroBenchmarks/ImageProcessing/AnisotropicDiffusion/CMakeLists.txt
@@ -1,6 +1,7 @@
 set(IMAGEPROC_UTILS MicroBenchmarks/ImageProcessing/utils)
 
-list(APPEND CPPFLAGS -I ${CMAKE_SOURCE_DIR}/${IMAGEPROC_UTILS} -std=c++11)
+list(APPEND CPPFLAGS -I ${CMAKE_SOURCE_DIR}/${IMAGEPROC_UTILS})
+list(APPEND CXX_FLAGS -std=c++11)
 
 llvm_test_verify("${CMAKE_SOURCE_DIR}/HashProgramOutput.sh ${CMAKE_CURRENT_BINARY_DIR}/anisotropicDiffusionOutput.txt")
 llvm_test_verify("${FPCMP} ${CMAKE_CURRENT_BINARY_DIR}/anisotropicDiffusionOutput.txt ${CMAKE_CURRENT_SOURCE_DIR}/anisotropicDiffusion.reference_output")


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D50379.159487.patch
Type: text/x-patch
Size: 3050 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180807/9704059b/attachment.bin>