[PATCH] D50310: Improve the legalisation lowering of UMULO

Simonas Kazlauskas via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 7 03:31:57 PDT 2018


nagisa added a comment.

In https://reviews.llvm.org/D50310#1190302, @efriedma wrote:

> No tests for umul.with.overflow.i64 on 32-bit?


Thanks for the review. On one hand, I ended up forgetting as it was getting late, on the other hand, those are already tested by the definition of the i128 umulo lowering which uses i64 umulo in its implementation. I will add a few tests targetting i64 umulo specifically later today.


https://reviews.llvm.org/D50310





More information about the llvm-commits mailing list