[PATCH] D50335: vs integration: fix default path to clang-cl

Hans Wennborg via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 7 01:59:07 PDT 2018


On Mon, Aug 6, 2018 at 6:37 PM, Zachary Turner via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
>
>
> On Mon, Aug 6, 2018 at 12:18 PM Hans Wennborg via Phabricator
> <reviews at reviews.llvm.org> wrote:
>>
>> hans added a comment.
>>
>> In https://reviews.llvm.org/D50335#1189459, @zturner wrote:
>>
>> > Btw, unfortunately i had a few more changes to the csproj file that I
>> > may
>> >  have forgotten to upstream before i left. IIRC, they were changing the
>> >  author name to LLVMExtensions , deleting the part in the csproj about
>> >  Brutal Strong name signer, setting the key file in project settings,
>> > and
>> >  fixing the path to sn.exe.
>>
>>
>> Ouch, it's not so great that the published extension was built from source
>> that's not checked in. But I guess publishing an updated version can wait
>> until you're back.
>
> It’s only a 3 or 4 line change, and you won’t be able to upload until
> they’re fixed so it shouldn’t be too hard if Youre willing to give it a try.

Okay, I'll give it a try.


More information about the llvm-commits mailing list